Fix default execution type in CLI and add test for run command#271
Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom Feb 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @pradeeban ,This pr fixes issue #260
Why this change?
concore rundefaults to--type windowson all platforms. On Linux/macOS this generates Windows scripts (.bat) and Windows commands, so the default Quick Start fails unless users override--type posix.What was the problem?
windowsHow I solved it
--typeOS-aware (windowson Windows,posixotherwise)Changes / Implementation
concore_cli/cli.py--typetests/test_cli.pytest_run_command_default_typeHow to Test Locally
python -m pytest -v tests/test_cli.py
python -m pytest -v
Evidence
python -m pytest -v57 passed in 2.41sPR Checklist